Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in github_actions_organization_secret #584

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Add in github_actions_organization_secret #584

merged 1 commit into from
Nov 23, 2020

Conversation

jacobfoard
Copy link
Contributor

This fixes #468.

This almost exclusively follows the same patterns as github_actions_secret, but happy to address any feedback!

I also fixed the updated_at and created_at fields on github_actions_secret from the string "default" to being a proper timestamp.

@ghost ghost added the size/XL label Nov 3, 2020
@jcudit
Copy link
Contributor

jcudit commented Nov 4, 2020

🎉 looking good on a quick glance.

Can we get a new file added under the website directory that documents this new resource?

I believe there would also be a change to add the new documentation to the side navigation area. I can link an example when at my keyboard.

Aiming to come back with a more thorough review as well. Thanks for kicking this one off @jacobfoard !

@ghost ghost added the Type: Documentation Improvements or additions to documentation label Nov 4, 2020
@jacobfoard
Copy link
Contributor Author

I added in handling a couple edge cases I hadn't previously tested, added/updated docs, and needed to add in the repo_id for use with the selected visibility.

@jcudit jcudit added this to the v4.0.0 milestone Nov 5, 2020
@jcudit
Copy link
Contributor

jcudit commented Nov 5, 2020

@jacobfoard gave this another read and caught a typo. github_actions_orginization_secret should be github_actions_organization_secret. Can you replace all occurrences when you get a moment?

@jcudit jcudit modified the milestones: v4.0.0, v4.1.0 Nov 5, 2020
@jacobfoard
Copy link
Contributor Author

@jcudit Done, and commits squashed as well.

@jacobfoard jacobfoard changed the title Add in github_actions_orginization_secret Add in github_actions_organization_secret Nov 5, 2020
jcudit
jcudit reviewed Nov 13, 2020
View reviewed changes
Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a few more fixes to make 😄 .

website/github.erb Outdated Show resolved Hide resolved
website/docs/r/actions_orginization_secret.html.markdown Outdated Show resolved Hide resolved
github/resource_github_actions_organization_secret_test.go Outdated Show resolved Hide resolved
github/resource_github_actions_organization_secret_test.go Show resolved Hide resolved
jcudit
jcudit reviewed Nov 22, 2020
View reviewed changes
Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close 🎉 . Take a look at the test fixes and commit if all is 👌 . Will look to release this in the upcoming week.

github/resource_github_actions_organization_secret_test.go Outdated Show resolved Hide resolved
github/resource_github_actions_organization_secret_test.go Outdated Show resolved Hide resolved
github/resource_github_actions_organization_secret_test.go Outdated Show resolved Hide resolved
github/resource_github_actions_organization_secret_test.go Outdated Show resolved Hide resolved
github/resource_github_actions_organization_secret_test.go Outdated Show resolved Hide resolved
github/resource_github_actions_organization_secret_test.go Outdated Show resolved Hide resolved
Adding in github_actions_organization_secret resource
733557a 
Signed-off-by: Jacob Foard <[email protected]>

fixing github_actions_secret created/updated timestamp

Signed-off-by: Jacob Foard <[email protected]>

docs, adding repo_id attribute for repository

Signed-off-by: Jacob Foard <[email protected]>

s/orginization/organization/

Signed-off-by: Jacob Foard <[email protected]>

rename file, add in require param to tests

Signed-off-by: Jacob Foard <[email protected]>

Fixing test copy pasta

Signed-off-by: Jacob Foard <[email protected]>
@jacobfoard
Copy link
Contributor Author

Alright, I believe the last of the copy pasta has been cleaned up. Thanks for your patience, I'll make sure my next contribution isn't as rushed 😅.

@jcudit
Copy link
Contributor

jcudit commented Nov 23, 2020

❤️ this contribution. Looks like a popular one from the community's view, so 🙇 for making everyone's life a bit easier. Aiming to release this week.

@jcudit jcudit merged commit ba42fb2 into integrations:master Nov 23, 2020
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@jacobfoard
Adding in github_actions_organization_secret resource (integrations#584)
2ce7092 
Signed-off-by: Jacob Foard <[email protected]>

fixing github_actions_secret created/updated timestamp

Signed-off-by: Jacob Foard <[email protected]>

docs, adding repo_id attribute for repository

Signed-off-by: Jacob Foard <[email protected]>

s/orginization/organization/

Signed-off-by: Jacob Foard <[email protected]>

rename file, add in require param to tests

Signed-off-by: Jacob Foard <[email protected]>

Fixing test copy pasta

Signed-off-by: Jacob Foard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcudit jcudit jcudit left review comments

Assignees
No one assigned
Labels
size/XL Type: Documentation Improvements or additions to documentation
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] Organization Secrets
2 participants
@jacobfoard @jcudit