[Feature Request] Organization Secrets

[ejhayes]

Thanks for rolling out support for secrets in #362. It looks like secrets are now supported at the organization level but this does not yet look to be supported by terraform:

https://github.blog/changelog/2020-05-14-organization-secrets/

API documentation:
https://developer.github.com/v3/actions/secrets/#get-an-organization-public-key

Adding support for this would be greatly appreciated!

[cj-taylor]

@ejhayes this looks to require a version upgrade of go-github in terraform-provider-github once Organization Secrets is made available in go-github. I tagged this issue in the Pull Request in go-github where I'm proposing the changes. google/go-github#1532

Once merged and available, I'll take a pass at the implementation in terraform-provider-github to address this issue!

[nikolay]

They just merged it, so, the library now support organization secrets.

[patrickmarabeas]

Rather than setting a plaintest_value, would it be possible to stipulate the env var holding the secret? This would probably allow the secret to remain out of the state file all together.

I'm planning on testing the theory out on resource_github_actions_secret when I get the change, but thought it would be good to call it out here prior to any development being kicked off.

[sc250024]

Yes please!

[nikolay]

Any update?

[cj-taylor]

PR for bumping the go-github version is still pending via https://github.com/terraform-providers/terraform-provider-github/pull/475

I have a local branch where I had built on top of that, but until that is merged in, we'll be in a holding pattern here!

[patrickmarabeas]

Referencing a POC PR to add RSA public key encryption as an option to github_actions_secret. Since this will basically be the same resource, thoughts? - #495

[ejhayes]

Checking in to see if there's any eta on when https://github.com/terraform-providers/terraform-provider-github/pull/475. Would be great to see this functionality available!

[andrew-waters]

https://github.com/terraform-providers/terraform-provider-github/pull/475 has taken in the latest go-github release which should have addressed the acceptance test failures fixed by @anGie44 in google/go-github#1571.

@cj-taylor hopefully this will unblock you on the functional side of this feature

[ejhayes]

@cj-taylor looks like #475 is approved and just needs to be merged in. Think you’ll be able to add your changes in?

[nikolay]

@jcudit Any ETA on when this will get released?

[jcudit]

@nikolay Thanks for the ping. Early next week is likely.

[jcudit]

The required go-github changes are merged in. Would ❤️ a PR for this one if anyone has the time. Will otherwise queue this behind the v3.1.1 to get an implementation up for review.

[nikolay]

@jcudit I am a newbie in this space, but if there's nobody else to volunteer, I can give it a try.

[ejhayes]

Thank you @jacobfoard!!!

[nikolay]

Thank you! At last! I hope this gets released ASAP!