Kayrus optional parameters #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form-provider-github into kayrus-optional-parameters
ghost
added
size/M
Type: Documentation
paddycarver
reviewed
Jul 16, 2019
| @@ -90,6 +102,59 @@ func TestProvider_individual(t *testing.T) { | |||
| Config: individualProviderConfig + testAccGithubMembershipConfig(username), | |||
| ExpectError: regexp.MustCompile("This resource requires GitHub organization to be set on the provider."), | |||
| }, | |||
| { | |||
| Config: conflictingProviderConfig + testAccCheckGithubUserDataSourceConfig(username), | |||
| ExpectError: regexp.MustCompile("If `individual` is true, `organization` cannot be set."), | |||
There was a problem hiding this comment.
Does this test pass? conflictingProviderConfig, from what I can see, only sets individual to true, it doesn't set an organization.
github/provider_test.go
Outdated
| ` | ||
|
|
||
| neitherProviderConfig := `provider "github" { | ||
| organization = "" |
There was a problem hiding this comment.
I think the more common user scenario, and the one we should probably be testing for, is that they didn't specify organization at all, rather than setting it to an empty string.
There was a problem hiding this comment.
@paddycarver I agree, however, the rest of the tests need GITHUB_ORGANIZATION defined, so, when running the suite it will already be there, this will override that. Is there a better way to do this?
paddycarver
approved these changes
Jul 22, 2019
This was referenced Jul 22, 2019
|
@megan07 when are you going to make the release with this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #230, #205, and #190 where GITHUB_TOKEN should not be required for all data sources.
Before fix:
After fix: