Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unauthenticated usage for public API endpoints #205

Closed
StephenKing opened this issue Mar 27, 2019 · 2 comments
Closed

Allow unauthenticated usage for public API endpoints #205

StephenKing opened this issue Mar 27, 2019 · 2 comments

Comments

@StephenKing
Copy link

Hi there,

Terraform Version

Run terraform -v to show the version. If you are not running the latest version of Terraform, please upgrade because your issue may have already been fixed.

Affected Resource(s)

Please list the resources as a list, for example:

  • data.github_ip_ranges
  • data.github_repositories
  • data.github_* actually..

Terraform Configuration Files

provider "github" {
  organization = "" # required setting
  token = "" # required setting
}

data "github_ip_ranges" "this" {}

output "github_ip_ranges_hooks" {
  value = "${data.github_ip_ranges.this.hooks}"
}

Expected Behavior

The API endpoint https://api.github.com/meta can be reached without authentication. It would be easier to use this data source (or the github data sources in general), if the provider wouldn't enforce that a token is given.

I know that rate limiting can kick in a lot earlier then. But for the use case of white-listing the IP addresses that GitHub uses to deliver hooks, our Terraform deployment would be easier and the number of calls sufficiently low.

Actual Behavior

I'm asked to provide a Github token.

@majormoses
Copy link
Contributor

@megan07
Copy link
Contributor

megan07 commented Jul 22, 2019

Thanks @StephenKing for opening this issue. It's been closed with #255 and will be released shortly.

@megan07 megan07 closed this as completed Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants