fix autodiscover test #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With intake/intake#526, `autodiscover` can not be imported directly from the intake module anymore.
This was referenced Sep 14, 2020
|
This is fine, I can merge it, but it could also be removed since entrypoints are now well-established. |
|
I've no preference for it and you most likely know the code a lot better than I do. My only goal has been to make the tests pass again. If the best solution is to drop the test, I am fine with it as well. If you like, I can change the PR accordingly. |
|
I'll merge as is - it can't hurt. If that discover method goes away, we can drop the test then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With intake/intake#526,
autodiscovercan notbe imported directly from the intake module anymore.