opendap driver: use no authentication as default #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apart from historic reasons, using ESGF as the default authentication method does not seem to be a straight forward choice. Changing the default to no authentication most likely is the more user friendly alternative. Apart from that and following intake#57, the default if no authentication method is given should be anonymous access, but currently this fall back does not work (see also intake#74).
|
The test should be fixed by #79 |
|
Can you please merge from master and rerun, to get this passing. |
|
I wonder if there are any xarray users (at pangeo?) that we should poll about possible breakages from the test. ( @rsignell-usgs ?) |
|
I'll raise this at today's pangeo meeting and merge if there are no problems |
|
I'm +1 on this change. In my experience, no auth opendap is the most common interface and I agree this should be the default. |
|
OK, that's good enough for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from historic reasons, using ESGF as the default authentication method does not seem to be a straight forward choice. Changing the default to no authentication most likely is the more user friendly alternative. Apart from that and following #57, the default if no authentication method is given should be anonymous access, but currently this fall back does not work (see also #74).
Be aware that this change may break other catalogs if they use ESGF and rely on the behaviour of using ESGF even if it is not specified in the catalog. If this is not an option, please feel free to reject the PR.