Merge with master of aiven/karapace to our repository #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split test_schema() to multiple single-purpose tests No essential functional changes in the tests
Instructions in README.rst Docker Compose file to start the Confluence stack
Changed the claim that Karapace is compatible to that aims to be compatible with 6.1.1 and added a list of known incompabilities.
Added information how to run integration tests against Confluence stack
Ft fix readme Configuration keys as table
…ec.html#names). Must not have '-'.
…to make the schema unique
…d as JSON strings
Split test schema Aiven-Open#221
For example in Avro field names '-' is not allowed. Using underscore instead.
New ones: test_schema_versions_multiple_subjects_same_schema and test_schema_versions_deleting The tests use unique schema names
Wasn't using a unique schema id. Added doc
Essentially a duplicate of test_enum_schema
Compares JSONs now, not strings.
Now uses a dynamic unique schema name. Was clashing before. Added documentation on what the test does.
The new ones: test_record_schema_compatibility_backward and test_record_schema_compatibility_forward
…ponse Now compatible with SR
Changed to use a proper Avro schema
No longer expects the exact same string schema to be returned. The str parsed as JSON needs to match.
The error message in POST to /subject/<subject> when schema is not specified in the request changed. Fixes test_schema_subject_post_invalid to run in Karapace and against Schema Registry
…rror-message schema_registry: breaking change in an error message
Fixed the error message in subjects/{}/versions/{} to match Schema Registry
Now test_schema_subject_invalid_id works against SR
Error message check matches the error from SR (was breaking the test) Dynamically fetches the version number Added description for the test
In the case the endpoint is submitted without body, changed the HTTP status code, error_code and message match the ones in Schema Registry. Made the necessary changes so that Karapace also returns correct values. test_schema.py: test_schema_missing_body fixed accordingly.
Now HTTP error messages match with the ones coming from Schema Registry. Adjusted test_http_headers in test_schema.py to correctly check the messages.
…versions-error-message
schema_registry: breaking change in subjects/{}/versions/{}
/schemas/ids/<schema_id:path>/versions now returns empty list in case nothing is found. This is the behaviour of SR. Karapace used to fail in this case before this change. The tests test_schema_lifecycle and test_schema_versions_deleting now works against Schema Registry (in addition to Karapace)
Unique field name not needed, schema name is enough. Using a fixed one.
…n-post-without-body-eror-message
schema_registry: breaking change in POST subjects/{subject}/versions
schema_registry: breaking change in /schemas/ids/<>/versions
moved documentation about development to the CONTRIBUTING.md file, and tried to make the README.rst a bit more concise.
…sages schema_registry: breaking changes in some HTTP error messages Aiven-Open#232
readme: clarified and separated readme
Only minor changes, no essential content change: Changed some rst formattings to md Some typos fixed such as karapace -> Karapace A few small tweaks
…-contributing-md CONTRIBUTING.md small fixes
Handle gracefully if no node is master eligible Aiven-Open#226
doc: fixed grammar
When started from KarapaceAll, the __init__ of KarapaceSchemaRegistry is not called. schema_lock is initialized in __init__. Thus it's not called when using KarapaceAll. Fix is to move schema_lock init to _init() which gets called also when using KarapaceAll.
…ace-all KarapaceAll: startup fix
docs: locahost -> localhost Aiven-Open#242
amrutha-shanbhag
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just apply aiven/karapace commits to our repostiory.