-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added information how to run integration tests against Confluence stack #223
Conversation
Instructions in README.rst Docker Compose file to start the Confluence stack
80b3e6e
to
e37d996
Compare
KAFKA_CONFLUENT_SCHEMA_REGISTRY_URL: http://schema-registry:8081 | ||
|
||
schema-registry: | ||
image: confluentinc/cp-schema-registry:6.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image: confluentinc/cp-schema-registry:6.1.1 | |
image: confluentinc/cp-schema-registry:latest |
Maybe this one should be also latest
tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Maybe we should fix the version we test against and aim for compatibility against that specific version?
Here are instructions from Confluent https://docs.confluent.io/platform/current/quickstart/ce-docker-quickstart.html#ce-docker-quickstart, and here https://github.com/confluentinc/cp-all-in-one/blob/6.1.1-post/cp-all-in-one/docker-compose.yml the compose file referred to in the instructions. In that file the versions are
confluentinc/cp-schema-registry:6.1.1
confluentinc/cp-kafka-rest:6.1.1
So, I think 6.1.1 for both would make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way, having latest
or 6.1.1
everywhere is fine as long as those are in sync. I'm a slighly favour of latest
actually as this is not automatically ran, so we might not want to spend effort to keep these in sync with CP's versioning until there is some automated test run, which we guarantee that tests will pass word-by-word?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to 6.1.1 for both.
Also added mentioning that Karapace aims to be compatible with 6.1.1 and listing of known incompatibilities.
Changed the claim that Karapace is compatible to that aims to be compatible with 6.1.1 and added a list of known incompabilities.
Instructions in README.rst
Docker Compose file to start the Confluence stack
About this change: What it does, why it matters
(all contributors please complete this section, including maintainers)