Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added information how to run integration tests against Confluence stack #223

Merged
merged 3 commits into from
May 19, 2021

Conversation

juha-aiven
Copy link
Contributor

Instructions in README.rst
Docker Compose file to start the Confluence stack

About this change: What it does, why it matters

(all contributors please complete this section, including maintainers)

@juha-aiven juha-aiven requested a review from a team as a code owner May 18, 2021 06:09
Instructions in README.rst
Docker Compose file to start the Confluence stack
@juha-aiven juha-aiven force-pushed the testing-against-confluent branch from 80b3e6e to e37d996 Compare May 18, 2021 07:07
KAFKA_CONFLUENT_SCHEMA_REGISTRY_URL: http://schema-registry:8081

schema-registry:
image: confluentinc/cp-schema-registry:6.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image: confluentinc/cp-schema-registry:6.1.1
image: confluentinc/cp-schema-registry:latest

Maybe this one should be also latest tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Maybe we should fix the version we test against and aim for compatibility against that specific version?

Here are instructions from Confluent https://docs.confluent.io/platform/current/quickstart/ce-docker-quickstart.html#ce-docker-quickstart, and here https://github.com/confluentinc/cp-all-in-one/blob/6.1.1-post/cp-all-in-one/docker-compose.yml the compose file referred to in the instructions. In that file the versions are

  • confluentinc/cp-schema-registry:6.1.1
  • confluentinc/cp-kafka-rest:6.1.1

So, I think 6.1.1 for both would make sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way, having latest or 6.1.1 everywhere is fine as long as those are in sync. I'm a slighly favour of latest actually as this is not automatically ran, so we might not want to spend effort to keep these in sync with CP's versioning until there is some automated test run, which we guarantee that tests will pass word-by-word?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to 6.1.1 for both.

Also added mentioning that Karapace aims to be compatible with 6.1.1 and listing of known incompatibilities.

Changed the claim that Karapace is compatible to that aims to be compatible with 6.1.1 and added a list of known incompabilities.
@tvainika tvainika merged commit 0f306a6 into master May 19, 2021
@tvainika tvainika deleted the testing-against-confluent branch May 19, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants