Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubsub subscription + topic #99

Merged
merged 21 commits into from
Jan 21, 2019

Conversation

slevenick
Copy link
Collaborator

Includes jnahelou's work from #95 as well as a couple refactoring changes. Generated from MM

jnahelou and others added 21 commits January 2, 2019 16:26
Signed-off-by: Modular Magician <[email protected]>
Add InSpec disk resource, refactors of attributes within examples and documentation
Remove extra braces from inspec ssl policy test
Signed-off-by: jnahelou <[email protected]>
Signed-off-by: Sam Levenick <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@@ -1,5 +1,6 @@
---
AllCops:
TargetRubyVersion: 2.4
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this to pin the ruby version rubocop was targeting. I was seeing errors in Travis due to default target ruby version that weren't showing up in my local environment and vice versa. I don't have an attachment to 2.4, just want something

Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @slevenick and @jnahelou !

@skpaterson skpaterson merged commit e9ee8aa into inspec:master Jan 21, 2019
skpaterson pushed a commit that referenced this pull request Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants