Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pubsub magicmodule #95

Merged
merged 6 commits into from
Jan 21, 2019
Merged

Conversation

jnahelou
Copy link
Contributor

@jnahelou jnahelou commented Jan 5, 2019

Following @slevenick great job on magic modules, I used it to generate pubsub services.

I need to merge name_from_self_link function in libraries/gcp_backend.rb to PR modifications made in my magic-module fork (because this file seems to be owned by modular-magician/inspec-gcp

@jnahelou jnahelou force-pushed the feat/pubsub-magicmodule branch from cc0415f to ca35855 Compare January 5, 2019 17:01
Signed-off-by: jnahelou <[email protected]>
This was referenced Jan 16, 2019
@skpaterson skpaterson merged commit 3fd41e6 into inspec:master Jan 21, 2019
skpaterson pushed a commit that referenced this pull request Mar 1, 2019
Add global forwarding rule generation to InSpec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants