Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Sync up guess endpoint to match plutus game contract #20

Closed

Conversation

luigy
Copy link
Contributor

@luigy luigy commented Jul 12, 2021

Fixes issue reported on plutus IntersectMBO/plutus#3526 , but there may still be a change in behavior for awaiting on slots introduced by IntersectMBO/plutus#3342 that needs to be investigated further as the changes introduced didn't use to be required prior to it

Copy link

@sorki sorki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue, thanks!

@sorki
Copy link

sorki commented Jul 16, 2021

Now the Hydra reports test failure

    Expose 'lock' endpoint, but not 'guess' endpoint:  FAIL
      Test failed.
      Emulator log:
      [INFO] Slot 0: TxnValidate af5e6d25b5ecb26185289a03d50786b7ac4425b21849143ed7e18bcd70dc4db8
      [INFO] Slot 1: 00000000-0000-4000-8000-000000000000 {Contract instance for wallet 1}:
                       Contract instance started
      [INFO] Slot 1: 00000000-0000-4000-8000-000000000000 {Contract instance for wallet 1}:
                       Contract log: String "Waiting for lock endpoint..."
        src/Plutus/Contract/Test.hs:241:
        Expose 'lock' endpoint, but not 'guess' endpoint

but I guess :-) this is a correct behavior as both endpoints needs to be exposed to be able to call either of them.

@luigy
Copy link
Contributor Author

luigy commented Jul 29, 2021

Yes, the tests would have to be updated to match the new behavior :), but instead I'll just close this as there might be things that landed upstream that should take care of this

@luigy luigy closed this Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants