plutus-contract: Reduce our use of row-types, delete BlockchainActions
#3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mueller
force-pushed
the
j-mueller/scp-2018-waiting-actions
branch
3 times, most recently
from
10afcfb to
9e14c9c
Compare
j-mueller
force-pushed
the
j-mueller/scp-2018-waiting-actions
branch
from
54ead2e to
857e869
Compare
koslambrou
reviewed
Jun 14, 2021
| GenericError e -> pretty e | ||
| ThreadIdNotFound i -> "Thread ID not found:" <+> pretty i | ||
| InstanceIdNotFound w -> "Instance ID not found:" <+> pretty w | ||
| EmulatorJSONDecodingError e v -> "emulator JSON decoding error:" <+> pretty e <+> parens (viaShow v) |
koslambrou
reviewed
Jun 14, 2021
| import qualified Control.Monad.Freer.Extras.Log as L | ||
| import qualified Control.Monad.Freer.Writer as W | ||
| import Ledger.AddressMap (UtxoMap) | ||
| import Prelude hiding (until) |
There was a problem hiding this comment.
hiding (until) not needed anymore
koslambrou
approved these changes
Jun 14, 2021
|
LGTM. Curiously, modules such as |
I meant to delete them when I was done but I forgot. Thanks for pointing it out! |
* Add proper type for BlockchainActions * Roll all 'Effects' into 'Contract.Request' * Change types in Plutus.Contract.Types [plutus-contract compiles] [plutus-contract compiles and tests pass]
j-mueller
force-pushed
the
j-mueller/scp-2018-waiting-actions
branch
from
17f4790 to
c650fec
Compare
koslambrou
reviewed
Jun 15, 2021
| @@ -199,7 +189,7 @@ tests = | |||
| matchLogs :: [EM.EmulatorTimeEvent ContractInstanceLog] -> Bool | |||
| matchLogs lgs = | |||
| case (_cilMessage . EM._eteEvent <$> lgs) of | |||
| [ Started, ContractLog "waiting for endpoint 1", CurrentRequests [_], ReceiveEndpointCall _, ContractLog "Received value: 27", HandledRequest _, CurrentRequests [], StoppedNoError] -> True | |||
| [ Started, ContractLog "waiting for endpoint 1", CurrentRequests [_], ReceiveEndpointCall{}, ContractLog "Received value: 27", HandledRequest _, CurrentRequests [], StoppedNoError] -> True | |||
There was a problem hiding this comment.
oh yes of course...
There was a problem hiding this comment.
hm no it passes locally?
koslambrou
approved these changes
Jun 15, 2021
This was referenced Jun 16, 2021
This was referenced Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockchainActionspart of the schema with a pair of typesPABReqandPABRespfor the requests/responses thatContracts can makerow-typesusage this also makes it much easier to see what actually gets passed to contract instancesmkSchemaTH function cannot handleEmptySchemaso I had to put a dummy endpoint in a couple of places in the playgroundContractPABRequestandContractPABResponsetypes. I deleted those.Pre-submit checklist:
Pre-merge checklist: