Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make parameters precedence on signer #529

Merged
merged 7 commits into from
Oct 3, 2022
Merged

make parameters precedence on signer #529

merged 7 commits into from
Oct 3, 2022

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Sep 28, 2022 •
edited
Loading

Content

This PR makes the parameters precedence the same for 3 CLI commands of the project.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No Clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #511

@github-actions
Copy link

github-actions bot commented Sep 29, 2022 •
edited
Loading

Unit Test Results

    7 files  ±0    24 suites  ±0   1m 40s ⏱️ -34s
337 tests ±0  337 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
338 runs  ±0  338 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9efe95c. ± Comparison against base commit 1836073.

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo force-pushed the greg/511/cli_param_precedence branch 3 times, most recently from 7ecad1d to 78499ac Compare September 30, 2022 08:35
jpraynaud
jpraynaud approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo merged commit a0d47d5 into main Oct 3, 2022
@ghubertpalo ghubertpalo deleted the greg/511/cli_param_precedence branch October 3, 2022 09:26
@jpraynaud jpraynaud mentioned this pull request Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghubertpalo @jpraynaud