Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI args precedence in Client/Signer/Aggregator #511

Closed
1 task
jpraynaud opened this issue Sep 20, 2022 · 1 comment
Closed
1 task

Fix CLI args precedence in Client/Signer/Aggregator #511

jpraynaud opened this issue Sep 20, 2022 · 1 comment
Assignees
@ghubertpalo
Labels
bug ⚠️ Something isn't working D-medium Difficulty: medium P-low Priority: low

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Sep 20, 2022 •
edited
Loading

Issue

The arguments passed through environment variables in the CLIs are ignored when a default value for a clap argument is set.

Task

  • Fix the precedence order of selection of arguments (or remove default values in clap)
@ghubertpalo ghubertpalo self-assigned this Sep 27, 2022
@ghubertpalo ghubertpalo mentioned this issue Oct 3, 2022
Merged
10 tasks
@jpraynaud jpraynaud mentioned this issue Oct 3, 2022
Merged
@ghubertpalo
Copy link
Collaborator

In the Client, we shall not have to provide GENESIS_VERIFICATION_KEY unless restoring.

jpraynaud added a commit that referenced this issue Oct 4, 2022
@jpraynaud
Fix launch Aggregator launch in devnet
c08e55e 
Following update of arguments precedence in #511
jpraynaud added a commit that referenced this issue Oct 4, 2022
@jpraynaud
Fix launch Aggregator launch in devnet
bd0c346 
Following update of arguments precedence in #511
jpraynaud added a commit that referenced this issue Oct 10, 2022
@jpraynaud
Fix launch Aggregator launch in devnet
077effe 
Following update of arguments precedence in #511
jpraynaud added a commit that referenced this issue Oct 10, 2022
@jpraynaud
Fix launch Aggregator launch in devnet
04126da 
Following update of arguments precedence in #511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghubertpalo ghubertpalo

Labels
bug ⚠️ Something isn't working D-medium Difficulty: medium P-low Priority: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpraynaud @ghubertpalo