Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAD-650 export OutcomeFidelity #531

Merged
merged 1 commit into from
Mar 10, 2020
Merged

CAD-650 export OutcomeFidelity #531

merged 1 commit into from
Mar 10, 2020

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Mar 9, 2020 •
edited
Loading

description

  • export type needed in outcome evaluation

checklist

  • compiles (cabal v2-build or stack build)
  • tests run successfully (cabal v2-test or stack test)
  • documentation added
  • link to an issue
  • add milestone (the current sprint)

@CodiePP CodiePP added minor Byron Byron rewrite labels Mar 9, 2020
@CodiePP CodiePP requested a review from deepfire March 9, 2020 19:58
@CodiePP CodiePP mentioned this pull request Mar 10, 2020
Merged
5 tasks
deepfire
deepfire approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CodiePP
CAD-650 export OutcomeFidelity
7b8c24b 
Signed-off-by: Alexander Diemand <[email protected]>
@CodiePP CodiePP force-pushed the cad-650-export-outcome-type branch from c723eb0 to 7b8c24b Compare March 10, 2020 09:10
@CodiePP CodiePP merged commit 43a912b into master Mar 10, 2020
@iohk-bors iohk-bors bot deleted the cad-650-export-outcome-type branch March 10, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire approved these changes

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@oneEdoubleD oneEdoubleD Awaiting requested review from oneEdoubleD

Assignees
No one assigned
Labels
Byron Byron rewrite minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodiePP @deepfire