Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAD-650 trace block forge time #653

Merged
merged 5 commits into from
Mar 10, 2020
Merged

CAD-650 trace block forge time #653

merged 5 commits into from
Mar 10, 2020

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Mar 9, 2020 •
edited
Loading

Issue

  • measure and trace block forge time

  • This PR does not result in breaking changes to upstream dependencies.

Checklist

  • This PR contains all the work required to resolve the linked issue.

  • The work contained has sufficient documentation to describe what it does and how to do it.

  • The work has sufficient tests and/or testing.

  • I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

  • I have added the appropriate labels to this PR.

@CodiePP CodiePP added WIP Work In Progress (cannot be merged yet) byron Required for a Byron mainnet: replace the old core nodes with cardano-node. labels Mar 9, 2020
@CodiePP CodiePP added this to the S8 2020-03-12 milestone Mar 9, 2020
@CodiePP CodiePP requested review from deepfire and Jimbo4350 March 9, 2020 20:00
@CodiePP CodiePP self-assigned this Mar 9, 2020
CodiePP added 3 commits March 10, 2020 08:50
@CodiePP
CAD-650 trace block forge time
28f479c 
Signed-off-by: Alexander Diemand <[email protected]>
@CodiePP
CAD-650 update iohk-monitoring fw
ed1f730 
Signed-off-by: Alexander Diemand <[email protected]>
@CodiePP
CAD-650 make pattern matches complete
581d52f 
Signed-off-by: Alexander Diemand <[email protected]>
@CodiePP
Copy link
Contributor Author

CodiePP commented Mar 10, 2020

we now get the right outcome:

{"at":"2020-03-10T07:52:16.00Z","env":"1.7.0:0fb3b",
"ns":["cardano.node.ForgeTime"],
"data":{"kind":"OutcomeTraceForgeEvent","difftime":130287000,"slot":2,"mempoolbytes":6754,"mempoolnumtx":22},
"app":[],"msg":"","pid":"2692","loc":null,"host":"nixos19","sev":"Info","thread":"41"}

@CodiePP
Copy link
Contributor Author

CodiePP commented Mar 10, 2020

depends on merging upstream PR input-output-hk/iohk-monitoring-framework#531 into master.

@CodiePP CodiePP force-pushed the cad-650-outcome-of-block-forge-time branch from 733627d to 581d52f Compare March 10, 2020 08:28
@CodiePP CodiePP removed the WIP Work In Progress (cannot be merged yet) label Mar 10, 2020
@CodiePP CodiePP marked this pull request as ready for review March 10, 2020 10:24
@CodiePP
CAD-650 references commit on master
0f1e00f 
Signed-off-by: Alexander Diemand <[email protected]>
@CodiePP CodiePP force-pushed the cad-650-outcome-of-block-forge-time branch from f3b174e to 0f1e00f Compare March 10, 2020 10:28
@CodiePP
CAD-650 removed commented out lines
e664030 
Signed-off-by: Alexander Diemand <[email protected]>
deepfire
deepfire approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CodiePP
Copy link
Contributor Author

CodiePP commented Mar 10, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 10, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit fe46216 into master Mar 10, 2020
@iohk-bors iohk-bors bot deleted the cad-650-outcome-of-block-forge-time branch March 10, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

Assignees

@CodiePP CodiePP

Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodiePP @deepfire