-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-257] Set up Shelley cardano-node selfnode environment #2462
Conversation
…elley-test-cluster
@@ -2667,14 +2673,14 @@ const _createWalletFromServerData = action( | |||
return { | |||
policyId: item.policy_id, | |||
assetName: item.asset_name, | |||
quantity: new BigNumber(item.quantity), | |||
quantity: new BigNumber(item.quantity.toString()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aleksandardjordjeviciohk @tomislavhoracek @yakovkaravelov @daniloprates @DominikGuzei we need to always convert quantities to string before passing them to BigNumber. This is a protection from JS number overflow. I have observed a lot of failures due to this happening in the selfnode environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikolaglumac Good catch. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikolaglumac Amazing work. Just left minor comments.
Would you please review them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikolaglumac This is incredible 💯 💯 💯
I left just 2 comments / questions, but BIG approve!!
This PR sets up Shelley cardano-node selfnode environment.
Todos
KEEP_LOCAL_CLUSTER_RUNNING
environment variablegetNetworkParameters
Api endpoint responseSelfnode
Run
yarn nix:selfnode
fromdaedalus
.Run
yarn dev
from the subsequentnix-shell
(useKEEP_LOCAL_CLUSTER_RUNNING
environment variable to keep the local cluster running after Daedalus exits:KEEP_LOCAL_CLUSTER_RUNNING=true yarn dev
)Once Daedalus has started and has gotten past the loading screen run the following commands from a new terminal window if you wish to import funded wallets:
yarn byron:wallet:importer
yarn shelley:wallet:importer
yarn mary:wallet:importer
(all of which contain native tokens which are visible once selfnode enters Mary era)yarn yoroi:wallet:importer
yarn itn:byron:wallet:importer
[Deprecated]yarn itn:shelley:wallet:importer
[Deprecated]These scripts import 3 wallets by default. You can import up to 10 wallets by supplying
WALLET_COUNT
environment variable (e.g.WALLET_COUNT=10 yarn mary:wallet:importer
).List of all funded wallet recovery phrases can be found here: https://github.com/input-output-hk/daedalus/blob/shelley-test-cluster/utils/api-importer/mnemonics.js
Notes:
Screenshots
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board