Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local-cluster: Change MA Faucet to use 24-word mnemonics #2569

Merged
merged 2 commits into from
Mar 19, 2021
Merged

local-cluster: Change MA Faucet to use 24-word mnemonics #2569

merged 2 commits into from
Mar 19, 2021

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Mar 18, 2021 •
edited
Loading

Issue Number

ADP-825

Overview

This is for Daedalus tests @nikolaglumac.

  • Change MA wallets to be 24 words so that they can be restored by the Daedalus UI (why is restoring 15-word wallets disabled though?).
  • Add 1000's of ada to these wallets.

Comments

The local-cluster MA faucet is a bit wacky, but hopefully we can replace it with minting transactions some time.

@rvl
local-cluster: Change MA Faucet to use 24-word mnemonics
f75bb4e 
This is for Daedalus tests, so that they can be restored by the
Daedalus UI.
@rvl rvl self-assigned this Mar 18, 2021
@rvl
Copy link
Contributor Author

rvl commented Mar 19, 2021

bors try

iohk-bors bot added a commit that referenced this pull request Mar 19, 2021
@iohk-bors
Try #2569:
b860876
@rvl rvl requested a review from Anviking March 19, 2021 08:00
@nikolaglumac
Copy link

Thanks @rvl - I have confirmed this works nicely.
Here's a PR in which I have integrated this rev into Daedalus: input-output-hk/daedalus#2462

Ready to be merged as far as I am concerned 👌

KtorZ
KtorZ approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

lib/core-integration/src/Test/Integration/Faucet.hs
@@ -959,108 +960,108 @@ seqMnemonics = unsafeMkMnemonic <$>
]
]

maMnemonics :: [Mnemonic 15]
maMnemonics :: [Mnemonic 24]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Anviking
Anviking approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 19, 2021 •
edited by rvl
Loading

try

Build failed:

Failures:

  src/Test/Integration/Scenario/CLI/Shelley/Wallets.hs:416:50: 
  1) CLI Specifications, SHELLEY_CLI_WALLETS, WALLETS_CREATE_08 - --address-pool-gap values, -1000 -> fail
       uncaught exception: IOException of type ResourceVanished
       fd:222: hFlush: resource vanished (Broken pipe)

  To rerun use: --match "/CLI Specifications/SHELLEY_CLI_WALLETS/WALLETS_CREATE_08 - --address-pool-gap values/-1000 -> fail/"

Randomized with seed 668596811

@rvl
Copy link
Contributor Author

rvl commented Mar 19, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 19, 2021
@iohk-bors @rvl
Merge #2569
631dff4 
2569: local-cluster: Change MA Faucet to use 24-word mnemonics r=rvl a=rvl

### Issue Number

ADP-825

### Overview

This is for Daedalus tests @nikolaglumac.

- Change MA wallets to be 24 words so that they can be restored by the Daedalus UI (why is restoring 15-word wallets disabled though?).
- Add 1000's of ada to these wallets.

### Comments

The local-cluster MA faucet is a bit wacky, but hopefully we can replace it with minting transactions some time.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 19, 2021 •
edited by rvl
Loading

Build failed:

Failures:

  src/Test/Integration/Scenario/API/Byron/Wallets.hs:187:59:
  1) API Specifications, BYRON_WALLETS, BYRON_RESTORE_01, GET_01, LIST_01 - Restore a wallet, icarus 12 words
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiByronWallet {id = ApiT {getApiT = WalletId {getWalletId = d53d41afafdd4ecd83385b9a2c0028766d9a8021}}, balance = ApiByronWalletBalance {available = Quantity {getQuantity = 0}, total = Quantity {getQuantity = 0}}, assets = ApiWalletAssetsBalance {available = ApiT {getApiT = TokenMap (fromList [])}, total = ApiT {getApiT = TokenMap (fromList [])}}, discovery = DiscoverySequential, name = ApiT {getApiT = WalletName {getWalletName = "Empty Byron Wallet"}}, passphrase = Just (ApiWalletPassphraseInfo {lastUpdatedAt = 2021-03-19 10:13:55.129477246 UTC}), state = ApiT {getApiT = Syncing (Quantity {getQuantity = Percentage {getPercentage = 0 % 1}})}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 0}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 0}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 0}}}, time = 2021-03-19 10:06:56 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 0}}}}))
       Waited longer than 90s to resolve action: "wallet is available and ready".
       expected: Ready
        but got: Syncing (Quantity {getQuantity = Percentage {getPercentage = 0 % 1}})

  To rerun use: --match "/API Specifications/BYRON_WALLETS/BYRON_RESTORE_01, GET_01, LIST_01 - Restore a

#2565

@rvl
Copy link
Contributor Author

rvl commented Mar 19, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 19, 2021
@iohk-bors @rvl
Merge #2569
8fac0d7 
2569: local-cluster: Change MA Faucet to use 24-word mnemonics r=rvl a=rvl

### Issue Number

ADP-825

### Overview

This is for Daedalus tests @nikolaglumac.

- Change MA wallets to be 24 words so that they can be restored by the Daedalus UI (why is restoring 15-word wallets disabled though?).
- Add 1000's of ada to these wallets.

### Comments

The local-cluster MA faucet is a bit wacky, but hopefully we can replace it with minting transactions some time.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 19, 2021 •
edited by Anviking
Loading

Build failed:

Failures:

  src/Test/Integration/Scenario/API/Shelley/StakePools.hs:503:5:
  1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_JOIN_01 - Can rejoin another stakepool
       uncaught exception: IOException of type UserError
       user error (next delegation should contain exactly one element)

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_JOIN_01 - Can rejoin another stakepool/"

#2497

@Anviking
Copy link
Member

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 19, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 1752820 into master Mar 19, 2021
@iohk-bors iohk-bors bot deleted the rvl/adp-825/ma-faucet branch March 19, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

@Anviking Anviking Anviking approved these changes

Assignees

@rvl rvl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rvl @nikolaglumac @Anviking @KtorZ