Ensure Plutus scripts are not executed when other failures already exist #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ValidationTagMismatch failure is unexpected since the transactions fails phase 1 validate (MalformedScriptWitnesses). The test can be reproduced inside cardano-ledger/libs/cardano-ledger-test with: TASTY_PATTERN="malformed script witness" cabal test
…e failure. In #2679 we got an implmentation of conditional execution. The intent was to prevent running some expensive predicate checks whenever there is already at least one existing predicate failure. That PR did not account for the fact that rules are executed in a recursive function and the state that carries information about predicate failures is not shared between each invocation. In other words, whenever one STS rule called another (eg. UTXOW calling UTXO), the invoked STS rules would be oblivious to previous failures.
JaredCorduan
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Thank you for resolving this @lehins , it looks great to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2838
Expectation was that #2679 has fixed this issue, however there was a tricky oversight that did not fix it for nested rules, but only for the immediate ones. In other words if UTXOS rule
whenFailureFreeit will only react to predicate failure produced by that rule alone and not the one that invoked it, i.e. the UTXO rule. This PR fixes that oversight and fixes the test that discovered this issue.It also enables this conditional execution for Babbage UTXOS rule only and not in the Alonzo, since this fix does not affect node syncing.