Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Well-formed script failure should prevent running phase 2 validation #2838

Closed
JaredCorduan opened this issue Jun 1, 2022 · 0 comments · Fixed by #2847
Closed

Well-formed script failure should prevent running phase 2 validation #2838

JaredCorduan opened this issue Jun 1, 2022 · 0 comments · Fixed by #2847

Comments

@JaredCorduan
Copy link
Contributor

JaredCorduan commented Jun 1, 2022 •
edited
Loading

We have at least one example where a malformed script both fails the well-formed check, but is still run through the plutus evaluator:

https://github.com/input-output-hk/cardano-ledger/pull/2837/files#diff-e87fb00b6caa153e54d2003b22f4cb8f9d8bfe0e5173b3ebc53bd8031c1842a2R997
@JaredCorduan JaredCorduan changed the title Well-formed script failure Well-formed script failure should prevent running phase 2 validation Jun 1, 2022
@JaredCorduan JaredCorduan mentioned this issue Jun 1, 2022
Merged
JaredCorduan pushed a commit that referenced this issue Jun 3, 2022
re-enable bug in #2838
232269b 
The ValidationTagMismatch failure is unexpected since the transactions
fails phase 1 validate (MalformedScriptWitnesses).

The test can be reproduced inside
cardano-ledger/libs/cardano-ledger-test with:

TASTY_PATTERN="malformed script witness" cabal test
@lehins lehins mentioned this issue Jun 6, 2022
Merged
teodanciu pushed a commit that referenced this issue Jun 14, 2022
@teodanciu
re-enable bug in #2838
e2da733 
The ValidationTagMismatch failure is unexpected since the transactions
fails phase 1 validate (MalformedScriptWitnesses).

The test can be reproduced inside
cardano-ledger/libs/cardano-ledger-test with:

TASTY_PATTERN="malformed script witness" cabal test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure Plutus scripts are not executed when other failures already exist IntersectMBO/cardano-ledger
1 participant
@JaredCorduan