Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Plutus scripts are not executed when other failures already exist #2847

Merged
merged 4 commits into from
Jun 6, 2022

Commits on Jun 3, 2022

  1. re-enable bug in #2838

    The ValidationTagMismatch failure is unexpected since the transactions
    fails phase 1 validate (MalformedScriptWitnesses).
    
    The test can be reproduced inside
    cardano-ledger/libs/cardano-ledger-test with:
    
    TASTY_PATTERN="malformed script witness" cabal test
    Jared Corduan committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    232269b View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2022

  1. Minor simplification

    lehins committed Jun 5, 2022
    Configuration menu
    Copy the full SHA
    85763ce View commit details
    Browse the repository at this point in the history
  2. Fix conditional execution of rules whenever there is already predicat…

    …e failure.
    
    In #2679 we got an implmentation of conditional execution. The intent
    was to prevent running some expensive predicate checks whenever there is
    already at least one existing predicate failure. That PR did not account
    for the fact that rules are executed in a recursive function and the
    state that carries information about predicate failures is not shared
    between each invocation. In other words, whenever one STS rule called
    another (eg. UTXOW calling UTXO), the invoked STS rules would be
    oblivious to previous failures.
    lehins committed Jun 5, 2022
    Configuration menu
    Copy the full SHA
    183ec4c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    da98163 View commit details
    Browse the repository at this point in the history