Feat/refactor native code #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
beer-1
added a commit
that referenced
this pull request
Oct 30, 2024
* wip: apply loader v2, need to fix move to json error * copy type conversion functions from runtime loader & handle json parsing error * bump aptos core loader v2 version * introduce InitiaModuleStorage using LRU module cache * introduce InitiaCodeStorage to connect InitiaModuleStorage * manage module cache as a single unit within the Initia VM * manage script cache as a single unit within the Initia VM * fmt and clippy * compiled module & script interface change * use custom move (#140) * update rust version * clone runtime_environment on every call * introduce lock on cache (#141) * use aptor-core move & flush type_cache every vm call * not cloning environment with flushed ty_cache * fix coderabbit audit * feat: deps code upgrade policy check (#144) * upgrade policy check to dependency modules * fix broken tests * pass policy check if dep is stdlib * add code publish tests * fmt and clippy * feat: implement flashswap (#142) * implement flashswap * fix typo; * fix missing pool_amounts conversion * change the impl to use hot potato pattern * fix typo and add borrow_amounts read function * rename get_borrow_amounts * movefmt * lock the pool at flash swap and disallow provide liquidity and swap operations * add testcases * fmt and rebuild * lock first before calling external functoins * add flash swap event * feat: support multisend cosmos interface (#143) * introduce multisend * remove unused from minitia_stdlib * add comments for the error handlings * change to call move function instead of reading table context data (#147) * change to call move function instead of reading table context data * lint * change to do not receive module_ids --------- Co-authored-by: beer-1 <[email protected]> Co-authored-by: beer-1 <[email protected]> * apply recent aptos update making struct index map to arc * calculate cache size using real heap size * fmt clippy * add storage & code conversion test * fix script access specifier * add code scale test code to be used in e2e test & debug code to identify equal structs * add panic handling when fetching size * apply merged version * Feat/refactor native code (#154) * change upgrade policy u8 to enum * code test cleanup & use loaderv2 as default * code module type * typo * nit error message change * cleanup module cache code * nit error message * delete type conversion funcs from sessionExt & use them from session directly * use 1 as cache weight for all cache items * minor lint fix * feat: use constant cache weight for all modules & scripts (#156) * use 1 as cache weight for all cache items * small refactor --------- Co-authored-by: beer-1 <[email protected]> Co-authored-by: beer-1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...