Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use custom move for loader v2 #140

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

beer-1
Copy link
Member

@beer-1 beer-1 commented Oct 14, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@beer-1 beer-1 self-assigned this Oct 14, 2024
@beer-1 beer-1 requested a review from a team as a code owner October 14, 2024 03:22
Copy link
Contributor

@sh-cha sh-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sh-cha sh-cha merged commit 4db894c into feat/vm-loaderv2 Oct 14, 2024
2 of 3 checks passed
@sh-cha sh-cha deleted the feat/use-custom-move branch October 14, 2024 03:27
beer-1 added a commit that referenced this pull request Oct 30, 2024
* wip: apply loader v2, need to fix move to json error

* copy type conversion functions from runtime loader & handle json parsing error

* bump aptos core loader v2 version

* introduce InitiaModuleStorage using LRU module cache

* introduce InitiaCodeStorage to connect InitiaModuleStorage

* manage module cache as a single unit within the Initia VM

* manage script cache as a single unit within the Initia VM

* fmt and clippy

* compiled module & script interface change

* use custom move (#140)

* update rust version

* clone runtime_environment on every call

* introduce lock on cache (#141)

* use aptor-core move & flush type_cache every vm call

* not cloning environment with flushed ty_cache

* fix coderabbit audit

* feat: deps code upgrade policy check (#144)

* upgrade policy check to dependency modules

* fix broken tests

* pass policy check if dep is stdlib

* add code publish tests

* fmt and clippy

* feat: implement flashswap (#142)

* implement flashswap

* fix typo;

* fix missing pool_amounts conversion

* change the impl to use hot potato pattern

* fix typo and add borrow_amounts read function

* rename get_borrow_amounts

* movefmt

* lock the pool at flash swap and disallow provide liquidity and swap operations

* add testcases

* fmt and rebuild

* lock first before calling external functoins

* add flash swap event

* feat: support multisend cosmos interface (#143)

* introduce multisend

* remove unused from minitia_stdlib

* add comments for the error handlings

* change to call move function instead of reading table context data (#147)

* change to call move function instead of reading table context data

* lint

* change to do not receive module_ids

---------

Co-authored-by: beer-1 <[email protected]>
Co-authored-by: beer-1 <[email protected]>

* apply recent aptos update making struct index map to arc

* calculate cache size using real heap size

* fmt clippy

* add storage & code conversion test

* fix script access specifier

* add code scale test code to be used in e2e test & debug code to identify equal structs

* add panic handling when fetching size

* apply merged version

* Feat/refactor native code (#154)

* change upgrade policy u8 to enum

* code test cleanup & use loaderv2 as default

* code module type

* typo

* nit error message change

* cleanup module cache code

* nit error message

* delete type conversion funcs from sessionExt & use them from session directly

* use 1 as cache weight for all cache items

* minor lint fix

* feat: use constant cache weight for all modules & scripts (#156)

* use 1 as cache weight for all cache items

* small refactor

---------

Co-authored-by: beer-1 <[email protected]>
Co-authored-by: beer-1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants