Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(igoMatBadgeIcon): empty matBadge directive cause icondirective to… #924

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

pelord
Copy link
Member

@pelord pelord commented Oct 15, 2021

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
fix(igoMatBadgeIcon): empty matBadge directive cause icondirective to crash

What is the new behavior?
throw error if the matBadge directive is empty WHEN an igoMatBadgeIcon directive is also used.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord pelord merged commit 9629b6e into next Oct 15, 2021
@pelord pelord deleted the matBadge branch October 15, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant