fix(igoMatBadgeIcon): empty matBadge directive cause icondirective to… (

#924) * fix(igoMatBadgeIcon): empty matBadge directive cause icondirective to crash
infra-geo-ouverte · Oct 15, 2021 · 9629b6e · 9629b6e
1 parent 4d0c8b2
commit 9629b6e
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/packages/common/src/lib/badge-icon/badge-icon.directive.ts b/packages/common/src/lib/badge-icon/badge-icon.directive.ts
@@ -1,6 +1,12 @@
 import { Directive, Input, ElementRef, OnInit } from '@angular/core';
 import { MatIconRegistry } from '@angular/material/icon';
 
+
+/**
+ * This directive allow to add an icon inside a matBadge.
+ * A value must be set into the matBadge directive ex: matBadge="icon".
+ * The badge content will be overrided by this current directive.
+ */
 @Directive({
   selector: '[igoMatBadgeIcon]'
 })

diff --git a/packages/geo/src/lib/catalog/catalog-browser/catalog-browser-layer.component.html b/packages/geo/src/lib/catalog/catalog-browser/catalog-browser-layer.component.html
@@ -27,7 +27,7 @@ <h4 mat-line matTooltipShowDelay="500" [ngClass]="(catalogAllowLegend)?'igo-cata
     [color]="(isPreview$ | async) ? '' : added ? 'warn' : ''"
     (click)="onToggleClick($event)">
     <mat-icon
-       matBadge
+       matBadge="icon"
        igoMatBadgeIcon="eye-off"
        igoMatBadgeInverseColor="true"
        [matBadgeHidden]="isInResolutionsRange()"

diff --git a/packages/geo/src/lib/layer/layer-list-tool/layer-list-tool.component.html b/packages/geo/src/lib/layer/layer-list-tool/layer-list-tool.component.html
@@ -32,7 +32,7 @@
          <button class="only-visible" mat-icon-button [disabled]="layersAreAllVisible && !onlyVisible"
            [color]="onlyVisible ? 'warn' : 'primary'" (click)="toggleOnlyVisible()">
            <mat-icon
-             matBadge
+             matBadge="icon"
              igoMatBadgeIcon="eye"
              igoMatBadgeInverseColor="true"
              igoMatBadgeInheritColor="true"

diff --git a/packages/geo/src/lib/search/search-results/search-results-add-button.component.html b/packages/geo/src/lib/search/search-results/search-results-add-button.component.html
@@ -8,7 +8,7 @@
 [color]="(isPreview$ | async) ? '' : added ? 'warn' : ''"
 (click)="onToggleClick($event)">
 <mat-icon
-  matBadge
+  matBadge="icon"
   igoMatBadgeIcon="eye-off"
   igoMatBadgeInverseColor="true"
   [matBadgeHidden]="(inRange$ | async)"