-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(utils): add an util to handle excel file export #1709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques commentaires de style et de type mais c'est bien beau tout ça, good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pour le nom du dossier, le export
dans file-export
, est-ce qu'on serait mieux d'être plus générique, car ça pourrait être utilisé tant pour lire que pour créer un fichier Excel. Je proposerais un dossier files, qu'est-ce que t'en pense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il y a déja un fichier nommé file.ts...
Proposition:
Je crée un dossier files, j'ajoute le fichier excel et le file.ts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes bon plan
🎉 This PR is included in version 18.0.0-next.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Please check if the PR fulfills these requirements
What is the new behavior?
Create an util to export data to excel file.
This new feature will be reused into an other PR.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: