Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): add an util to handle excel file export #1709

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

pelord
Copy link
Member

@pelord pelord commented Dec 4, 2024

Please check if the PR fulfills these requirements

What is the new behavior?
Create an util to export data to excel file.

This new feature will be reused into an other PR.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord pelord marked this pull request as ready for review December 4, 2024 22:27
@pelord pelord requested a review from alecarn December 4, 2024 22:44
Copy link
Collaborator

@alecarn alecarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques commentaires de style et de type mais c'est bien beau tout ça, good job!

packages/utils/src/lib/file-export/excel.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour le nom du dossier, le export dans file-export, est-ce qu'on serait mieux d'être plus générique, car ça pourrait être utilisé tant pour lire que pour créer un fichier Excel. Je proposerais un dossier files, qu'est-ce que t'en pense?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a déja un fichier nommé file.ts...

Proposition:

Je crée un dossier files, j'ajoute le fichier excel et le file.ts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes bon plan

packages/utils/src/lib/file-export/excel.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/files/excel.ts Outdated Show resolved Hide resolved
packages/utils/src/lib/files/excel.ts Outdated Show resolved Hide resolved
@pelord pelord merged commit 0ca05f3 into next Dec 11, 2024
3 checks passed
@pelord pelord deleted the feature/excel-export-util branch December 11, 2024 15:59
@alecarn
Copy link
Collaborator

alecarn commented Dec 11, 2024

🎉 This PR is included in version 18.0.0-next.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants