Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog service list generator #1282

Open
wants to merge 69 commits into
base: next
Choose a base branch
from

Conversation

ThierryNormand
Copy link
Contributor

Create a button to generate the list of layers used in the catalogs of the application.
Loop through the catalogs and determine the context of the layer.
Automatically creates and download a .CSV file for the user.

@ThierryNormand ThierryNormand requested a review from pelord June 9, 2023 14:52
@ThierryNormand ThierryNormand self-assigned this Jun 9, 2023
@pelord pelord changed the base branch from next to release/16.0.0 October 19, 2023 16:02
@pelord pelord changed the base branch from release/16.0.0 to next October 19, 2023 16:08
@pelord pelord changed the base branch from next to release/16.0.0 October 19, 2023 16:09
@pelord
Copy link
Member

pelord commented May 16, 2024

@alecarn ready for review!

@pelord
Copy link
Member

pelord commented Nov 29, 2024

@alecarn pret pour un seconde review.

packages/geo/src/lib/catalog/shared/catalog.interface.ts Outdated Show resolved Hide resolved
})
),
this.contextService
.getLocalContexts()
Copy link
Collaborator

@alecarn alecarn Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai encore de la difficulté à comprendre ce bout là getCatalogsAndItemsAndDetailedContexts et getCatalogList, pourquoi qu'on jumèle les deux listes Catalogues et Contextes pour ensuite dans getCatalogList les reséparé en deux liste pour gérer de la logique d'affaire par liste. J'ai l'impression qu'on merge rapidement les listes ce qui complexifie la lisibilité.

Catalogue:

  1. preloadCatalogItems => Observable
  2. Gérer la logique de catalogue items et formatter enListExport

Context:

  1. getLocalContexts et preload des contextes => Observable
  2. getInfoFromSourceOptions

C'est des petits détails qui ne change pas le fonctionnement mais qui faciliterait la lisibilité/maintenance des prochains développeur.

@pelord
Copy link
Member

pelord commented Dec 4, 2024

@alecarn Peux tu revalider, j'ai fait les modifs selon tes commentaires.

Je vais travailler aujourd'hui pour faire le PR pour les utilitaires excell et remodifier cette pr après!

@pelord pelord changed the base branch from next to feature/excel-export-util December 4, 2024 22:33
Base automatically changed from feature/excel-export-util to next December 11, 2024 15:59
@pelord pelord requested a review from alecarn December 11, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants