-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catalog service list generator #1282
base: next
Are you sure you want to change the base?
Conversation
…vice_listGenerator
…vice_listGenerator
@alecarn ready for review! |
@alecarn pret pour un seconde review. |
packages/integration/src/lib/catalog/catalog-library-tool/catalog-library-tool.component.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/datasource/shared/datasources/any-datasource.utils.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/datasource/shared/datasources/any-datasource.interface.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/datasource/shared/datasources/any-datasource.utils.ts
Outdated
Show resolved
Hide resolved
packages/integration/src/lib/catalog/catalog-library-tool/catalog-library-tool.component.ts
Outdated
Show resolved
Hide resolved
packages/integration/src/lib/catalog/catalog-library-tool/catalog-library-tool.component.ts
Outdated
Show resolved
Hide resolved
packages/integration/src/lib/catalog/catalog-library-tool/catalog-library-tool.utils.ts
Outdated
Show resolved
Hide resolved
packages/integration/src/lib/catalog/catalog-library-tool/catalog-library-tool.component.ts
Outdated
Show resolved
Hide resolved
}) | ||
), | ||
this.contextService | ||
.getLocalContexts() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai encore de la difficulté à comprendre ce bout là getCatalogsAndItemsAndDetailedContexts
et getCatalogList
, pourquoi qu'on jumèle les deux listes Catalogues et Contextes pour ensuite dans getCatalogList
les reséparé en deux liste pour gérer de la logique d'affaire par liste. J'ai l'impression qu'on merge rapidement les listes ce qui complexifie la lisibilité.
Catalogue:
- preloadCatalogItems => Observable
- Gérer la logique de catalogue items et formatter enListExport
Context:
- getLocalContexts et preload des contextes => Observable
- getInfoFromSourceOptions
C'est des petits détails qui ne change pas le fonctionnement mais qui faciliterait la lisibilité/maintenance des prochains développeur.
@alecarn Peux tu revalider, j'ai fait les modifs selon tes commentaires. Je vais travailler aujourd'hui pour faire le PR pour les utilitaires excell et remodifier cette pr après! |
Create a button to generate the list of layers used in the catalogs of the application.
Loop through the catalogs and determine the context of the layer.
Automatically creates and download a .CSV file for the user.