-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for jsonrpc id #298
Conversation
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
========================================
+ Coverage 30.8% 31.0% +0.2%
========================================
Files 129 129
Lines 4893 4905 +12
Branches 1549 1549
========================================
+ Hits 1511 1525 +14
+ Misses 2297 2294 -3
- Partials 1085 1086 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with it as it is, although it would be nice to name the function something a bit more telling.
#196 (comment)
part of #211