tendermint/0.33 / #196 followup issue

[liamsi]

Collecting all outstanding discussions for full 0.33 compatibility and review comments from #196 and #199 and related issues here:

• Add changelog entries before release
• address @melekes comments: Tendermint/v0.33 #196 (review) (addressed in 0.33 compat followup #296)

---

• JSON / RPC issues: Tendermint/v0.33 #196 (comment) and Tendermint/v0.33 #196 (comment)
• investigate why above isn't detected by the integration tests

@ancazamfir re-tested this and it

Seems ok now

This was likely resolved as part of the serialization refactoring @greg-szabo did.

---

• tests for jsonrpc ID: Tendermint/v0.33 #196 (comment) (done in Add tests for jsonrpc id #298 )
• err handling weirdness: Tendermint/v0.33 #196 (comment) (this got resolved / outdated in the several serialzation improvement PRs and using blockIfFlags)
• review of commit followup #199: commit followup #199 (comment), commit followup #199 (comment), commit followup #199 (comment) (time was addressed in CommitSig refactor #277 and the remaining work was done in the commitsig refactoring PRs)
• delete AsRef completely: Tendermint/v0.33 #196 (comment) (was done after 0.33 PR was merged)
• move Proof: Update Proof and ProofOp #206 (review) (done in: Move proof.rs to merkle module #297)

[liamsi]

I think #196 (comment) is resolved. At least I would think this would be caught by the integration tests 🙏
Nah, NVM:

investigate why above isn't detected by the integration tests

[liamsi]

tests for jsonrpc ID: #196 (comment)

This would become obsolete if we switched to using an jsonrpc library instead. Otherwise the tests I had in mind would look similar to: https://github.com/paritytech/jsonrpc/blob/ef92a481d76802da489f0f57dfdf4d459d7f7f76/core/src/types/id.rs#L16

[liamsi]

Regarding the last point:

move Proof: #206 (review)

There is also a separate tracking issue: #207
Will comment there but tldr: the struct in abci is only there for serialzation. I think it isn't as displaced as it looks in the first place.

[liamsi]

This issue can be closed when #297 and #298 are merged.

[liamsi]

All comments addressed as far as I can see.