Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make encode_vec() infallible #1093

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Conversation

hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Feb 14, 2022

Closes: #1064

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #1093 (5010ee2) into master (904862c) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1093     +/-   ##
========================================
- Coverage    64.6%   64.6%   -0.1%     
========================================
  Files         239     239             
  Lines       20695   20691      -4     
========================================
- Hits        13387   13381      -6     
- Misses       7308    7310      +2     
Impacted Files Coverage Δ
proto/src/lib.rs 100.0% <100.0%> (ø)
proto/tests/unit.rs 94.8% <100.0%> (ø)
tendermint/src/block/header.rs 99.2% <100.0%> (-0.1%) ⬇️
tendermint/src/public_key.rs 75.1% <100.0%> (ø)
tendermint/src/validator.rs 73.6% <100.0%> (ø)
tendermint/src/vote/sign_vote.rs 96.5% <100.0%> (ø)
tendermint/src/block/commit_sig.rs 78.4% <0.0%> (-2.0%) ⬇️
light-client-verifier/src/types.rs 37.9% <0.0%> (-0.6%) ⬇️
abci/src/server.rs 9.4% <0.0%> (+0.1%) ⬆️
testgen/src/header.rs 84.4% <0.0%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904862c...5010ee2. Read the comment docs.

@hu55a1n1 hu55a1n1 marked this pull request as ready for review February 14, 2022 12:09
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor recommendation regarding the changelog entry - I'll make the change.

Thanks @hu55a1n1!

@thanethomson thanethomson merged commit c70f6ee into master Feb 14, 2022
@thanethomson thanethomson deleted the hu55a1n1/1064-infallible--encode-vec branch February 14, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

encode_vec() isn't infallible
3 participants