Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tendermint ConsensusState -> Any can crash if out of memory #747

Closed
plafer opened this issue Jul 5, 2023 · 2 comments · Fixed by #754
Closed

Tendermint ConsensusState -> Any can crash if out of memory #747

plafer opened this issue Jul 5, 2023 · 2 comments · Fixed by #754
Labels
O: security Objective: aims to enhance security and improve safety
Milestone

Comments

@plafer
Copy link
Contributor

plafer commented Jul 5, 2023

Here.

This probably involves updating tendermint-rs's Protobuf in a similar way that was done for the Protobuf in ibc-proto-rs (which removed the Result return for encode_vec()).

@plafer plafer added the O: security Objective: aims to enhance security and improve safety label Jul 5, 2023
@DaviRain-Su
Copy link
Contributor

DaviRain-Su commented Jul 10, 2023

I don't know, Why use

this Protobuf, otherwise ibc_proto::protobuf::Protobuf.
https://github.com/cosmos/ibc-proto-rs/blob/9e87819bf686d2fd93d1e338943c9721fc0f3e50/src/protobuf/mod.rs#L74

I think this maybe help this.

@DaviRain-Su
Copy link
Contributor

find this: informalsystems/tendermint-rs#1093

@Farhad-Shabani Farhad-Shabani added this to the v0.43.0 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: security Objective: aims to enhance security and improve safety
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants