Added TLS backend selection features & Default, removed get_/Get prefixes
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdingly, fixed line breaks (proper markdown) and headline capitalization in README.
…ked out code not used for some features.
|
That spellcheck will never succeed btw. for obvious reasons. |
* Simplified `new()` where possible. * Renamed `enum` variants to `PascalCase` (Rust naming guidelines). * Removed `get_` prefix from all getters/everywhere (Rust naming guidelines). * Simplified some places.
virtualritz
changed the title
Default, removed get_ prefixes
…efixed methods which have since been renamed."
virtualritz
changed the title
Default, removed get_ prefixesDefault, removed get_/Get prefixes
ukmadlz
reviewed
Apr 19, 2024
ukmadlz
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason is that
request's default TLS dependency pulls inopensslwhich wraps the OpenSSL C-lib viaopenssl-sys.This not only adds a noticable hiccup to build times, it also requires a resp. C compiler toolchain which can be a PITA when cross-compilation for other platform targets is needed (e.g. Android or iOS).
reqwestoffers a bunch of alternative TLS backends, exposed by feature flags.With this PR they're all also available in the
infobip_sdkcrate.This PR also puts some code behind
#[cfg(feature=...)]gates to get rid of some warnings and further decrease build time.