Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_/Get prefixes #16

Open
virtualritz opened this issue Jan 30, 2024 · 0 comments
Open

Remove get_/Get prefixes #16

virtualritz opened this issue Jan 30, 2024 · 0 comments

Comments

@virtualritz
Copy link
Contributor

virtualritz commented Jan 30, 2024

See Rust naming conventions on getters.

All of these getters in this crate are async (unless I overlooked something). I.e. the fact that they do work is obvious at any invocation site from the trailing .await.

If you nevertheless want to be explicit and add a prefix verb still, I'd go with maybe request_ or fetch_ instead (personally I'd just strip the get_ and be done with it though). 😁

Furthermore, I removed the Get prefixes from the names of matching structs, that are used to supply parameters to the resp. methods. I.e. they were named as such so that struct name matches function name and this change makes sure this is still the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant