-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend kube_inventory plugin to include resourcequota measurement and extend node and pod measurement #9627
Conversation
1e68d88
to
bfd235c
Compare
fcaa5b1
to
99a25e0
Compare
…nt and extend node and pod measurement
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
@varunjain0606 thank you for contributing this pull request, it looks like there are some issues with the tests. Do you have time to continue working on this? |
…nt and extend node and pod measurement
…nt and extend node and pod measurement - lint fix
@sspaink I have fixed the test cases. This PR has few changes that can be split into 2 or 3 PRs. Please let me know if you want me to split them. I have requirement for all of these changes along with some other changes that I can submit in the follow up PRs. These changes can be really helpful to monitor k8s infrastructure for everyone. Thanks |
@varunjain0606 it looks like there are two files |
…nt and extend node and pod measurement - removing unncessary bin files
Sorry for the unnecessary files in the PR. I have removed them now. Please have a look at the PR again @sspaink |
Kuberenetes node currently exposed several node conditions:
The condition status value might be string value The #10147 PR just adds those conditions as new fields on
It seems that this PR (#9627) treats this part in way that: Add a |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 🥳 This pull request decreases the Telegraf binary size by -3.75 % for linux amd64 (new size: 142.9 MB, nightly size 148.5 MB) 📦 Click here to get additional PR build artifactsArtifact URLs |
Hi @varunjain0606, Sorry that no one ever got back to you on this PR. Are you still interested in seeing it land? If so, could I have you rebase on master and ensure tests pass? Thanks! |
Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Page. Thank you! |
Checks:
Requirements:
Requirements have been included in the link below
#9621
Resolves
Included some more metrics in kubernetes_node, kubernetes_pod_container measurement in kube_inventory plugin as that would enhance the monitoring of k8s. Also add a resource type "resourcequotas" for even better monitoring of quota management.
Description:
Added these new metrics in kubernetes_node measurement within kube_inventory plugin.
Added tags:
Added these new metrics in kubernetes_pod_container measurement within kube_inventory plugin.
Added tags:
Added new kubernetes_resourcequota measurement and added these metrics
Added tags:
Example:
Output -
kubernetes_node,host=vjain count=8i 1628918652000000000
kubernetes_node,condition=Ready,host=vjain,node_name=ip-172-17-0-2.internal,status=True status_condition=1i 1629177980000000000
kubernetes_node,cluster_namespace=tools,condition=Ready,host=vjain,node_name=ip-172-17-0-2.internal,status=True allocatable_cpu_cores=4i,allocatable_memory_bytes=7186567168i,allocatable_millicpu_cores=4000i,allocatable_pods=110i,capacity_cpu_cores=4i,capacity_memory_bytes=7291424768i,capacity_millicpu_cores=4000i,capacity_pods=110i,spec_unschedulable=0i,status_condition=1i 1628918652000000000
kubernetes_pod_container,condition=Ready,host=vjain,pod_name=uefi-5997f76f69-xzljt,status=True status_condition=1i 1629177981000000000
kubernetes_resourcequota,host=vjain,namespace=default,resource=pods-medium hard_cpu_cores=10i,hard_memory_bytes=21474836480i,hard_pods=10i,used_cpu_cores=0i,used_memory_bytes=0i,used_pods=0i 1629110393000000000