feat(inputs.kubernetes): Extend kube_inventory plugin to include resourcequota,secrets measurement and extend node and pod measurement #13040
Conversation
telegraf-tiger
bot
added
the
feat
There was a problem hiding this comment.
Hi,
Thanks for putting this up again. I took a quick high-level look at this and have a couple questions about what each field/tags, plus some in-line questions:
spec_schedulable
Should this be spec_unschedulable? I do not see spec_schedulable called out in the examples, readme, or code.
|
@powersj I have submitted the changes. Please have a look. |
powersj
added
the
ready for final review
There was a problem hiding this comment.
@varunjain0606 thanks for this great contribution! I do have some minor comments...
Additionally I think this PR count for at least three different ones, so please split those up next time as this also eases review...
|
@varunjain0606 can you please take a look at my comments!? |
|
Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Page. Thank you! |
|
@varunjain0606 I thought you were pretty close to wrapping up this PR! Do you still want to wrap up @srebhan's comments and get this landed? |
telegraf-tiger
bot
removed
the
waiting for response
|
no worries :) I certainly didn't want to see this PR get dropped entirely. I will re-open it and feel free to update it as you have time. |
…nt and extend node and pod measurement
…nt and extend node and pod measurement
…nt and extend node and pod measurement - lint fix
…nt and extend node and pod measurement - removing unncessary bin files
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Looks good to me. Thanks for your contribution and effort @varunjain0606!
srebhan
changed the title
srebhan
added
area/k8s
plugin/input
|
@powersj assigning it back to you to have a final view after the changes... |
Checks:
Requirements:
Requirements have been included in the link below
#9621
Resolves
Included some more metrics in kubernetes_node, kubernetes_pod_container measurement in kube_inventory plugin as that would enhance the monitoring of k8s. Also add a resource type "resourcequotas" for even better monitoring of quota management.
Description:
Added these new metrics in kubernetes_node measurement within kube_inventory plugin.
Added tags:
Added these new metrics in kubernetes_pod_container measurement within kube_inventory plugin.
Added tags:
Added new kubernetes_resourcequota measurement and added these metrics
Added tags:
Example:
Output -
kubernetes_node,host=vjain count=8i 1628918652000000000
kubernetes_node,condition=Ready,host=vjain,node_name=ip-172-17-0-2.internal,status=True status_condition=1i 1629177980000000000
kubernetes_node,cluster_namespace=tools,condition=Ready,host=vjain,node_name=ip-172-17-0-2.internal,status=True allocatable_cpu_cores=4i,allocatable_memory_bytes=7186567168i,allocatable_millicpu_cores=4000i,allocatable_pods=110i,capacity_cpu_cores=4i,capacity_memory_bytes=7291424768i,capacity_millicpu_cores=4000i,capacity_pods=110i,spec_unschedulable=0i,status_condition=1i 1628918652000000000
kubernetes_pod_container,condition=Ready,host=vjain,pod_name=uefi-5997f76f69-xzljt,status=True status_condition=1i 1629177981000000000
kubernetes_resourcequota,host=vjain,namespace=default,resource=pods-medium hard_cpu_cores=10i,hard_memory_bytes=21474836480i,hard_pods=10i,used_cpu_cores=0i,used_memory_bytes=0i,used_pods=0i 1629110393000000000