Add protocol stats to the network plugin #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
force-pushed
the
nc-net-protos
branch
from
50dc16b
to
4fba65c
Compare
| @@ -42,6 +42,7 @@ same type. | |||
| - [#364](https://github.com/influxdb/telegraf/pull/364): Support InfluxDB UDP output. | |||
| - [#370](https://github.com/influxdb/telegraf/pull/370): Support specifying multiple outputs, as lists. | |||
| - [#372](https://github.com/influxdb/telegraf/pull/372): Remove gosigar and update go-dockerclient for FreeBSD support. Thanks @MerlinDMC! | |||
| - [#382](https://github.com/influxdb/telegraf/pull/382): Add system wide network protocol stats to `net` plugin. | |||
There was a problem hiding this comment.
this should go higher up, under 0.2.3
|
looks good, thanks @nathanielc! will get this merged once the gopsutil PR is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add the system wide network protocol stats to the
netplugin.Uses a new method in
gopsutilsee shirou/gopsutil#109Basically exposes all the data in
/proc/net/snmpasnet_PROTOCOL_COLNAMEfor example:
Excerpt from /proc/net/snmp
adds measurement
net_udp_rcvbuferrorswith value 58108572 etc.