Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate protocol stats in net input plugin #13248

Closed
dpward opened this issue May 5, 2023 · 2 comments · Fixed by #13608
Closed

Deprecate protocol stats in net input plugin #13248

dpward opened this issue May 5, 2023 · 2 comments · Fixed by #13608
Assignees
Labels
help wanted Request for community participation, code, contribution plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins rfc Request for comment - larger issues that require clarification size/s 1 day effort, great beginniner issue

Comments

@dpward
Copy link

dpward commented May 5, 2023

#382 adjusted the net input plugin to obtain protocol statistics, by reading /proc/net/snmp. This is only possible under Linux, and the data is completely orthogonal to everything else that the net plugin collects (none of the same fields are used in the measurements, and it is not keyed by network interface). The documentation says this behavior is available "for the time being", and it can be disabled with the configuration option ignore_protocol_stats = true.

The nstat plugin (#1104) was introduced shortly afterwards. It not only collects the same data from /proc/net/snmp, but also the data in /proc/net/snmp6 and /proc/net/netstat. It also lists the resulting metrics in its documentation.

I believe the net plugin should deprecate (and eventually remove) protocol statistics collection, by making ignore_protocol_stats = true the default and adjusting the documentation to discourage its use. This will simplify its behavior and greatly reduce the amount of data it produces by default.

@Hipska Hipska added rfc Request for comment - larger issues that require clarification plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 8, 2023
@Hipska
Copy link
Contributor

Hipska commented May 8, 2023

Changing the default behaviour can become difficult to convince the maintainers, but it definitely makes sense to add depreciation notices as there is a working alternative..

@powersj
Copy link
Contributor

powersj commented May 8, 2023

+1 to deprecation notice to at least start

next steps: add deprecation to the config option

@powersj powersj added help wanted Request for community participation, code, contribution size/s 1 day effort, great beginniner issue labels May 8, 2023
@srebhan srebhan self-assigned this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Request for community participation, code, contribution plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins rfc Request for comment - larger issues that require clarification size/s 1 day effort, great beginniner issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants