Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.openstack): Use service catalog from v3 authentication if available #15460

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jun 5, 2024

Summary

Querying available services via the services API requires admin permissions, however when registering to a v3 endpoint, the server sends a service catalog in the response.

This PR checks if we got the service catalog in the response and if so, skips the querying of the services endpoint.

Checklist

  • No AI generated code was used in this PR

Related issues

partially solves #11769

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 5, 2024
@srebhan srebhan marked this pull request as ready for review June 6, 2024 12:44
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jun 6, 2024

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 7, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Jun 7, 2024
@powersj powersj removed their assignment Jun 7, 2024
@DStrand1 DStrand1 merged commit 94a5ab6 into influxdata:master Jun 7, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants