Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openstack plugin - allow metrics-gathering by non-admin OSP accounts #11769

Closed
rplevka opened this issue Sep 6, 2022 · 3 comments · Fixed by #15468
Closed

Openstack plugin - allow metrics-gathering by non-admin OSP accounts #11769

rplevka opened this issue Sep 6, 2022 · 3 comments · Fixed by #15468
Labels
feature request Requests for new plugin and for new features to existing plugins plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins

Comments

@rplevka
Copy link
Contributor

rplevka commented Sep 6, 2022

Use Case

telegraf version: v1.23.2
input plugin: openstack

My OSP account does not have permissions to list the services, but it is perfectly capable of accessing other services API.

The current implementation of the plugin seem to rely on the calls to <auth_endpoint>/v3/services, rendering the plugin unusable with non-admin accounts.

Not sure what the request is used for, but the service catalog object is retrieved automatically after a successful authentication with the keystone service:
https://docs.openstack.org/keystone/latest/api_curl_examples.html

maybe parsing this catalog should be sufficient?

Expected behavior

admin permissions should not be required, service catalog should be parsed from the keystone authentication response

Actual behavior

plugin trying to gather the services by accessing the endpoint that requires admin privileges

Additional info

No response

@rplevka rplevka added the feature request Requests for new plugin and for new features to existing plugins label Sep 6, 2022
@Hipska Hipska added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Sep 6, 2022
@powersj
Copy link
Contributor

powersj commented Sep 7, 2022

@singamSrikar - any thoughts on this approach?

@srebhan
Copy link
Member

srebhan commented Jun 10, 2024

@rplevka please test the PR in #15468 and let me know if that works for you!

@rplevka
Copy link
Contributor Author

rplevka commented Jun 11, 2024

@srebhan hi, commented under the PR. The changes seem to work nicely. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants