Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.gnmi): Add keepalive settings #15171

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Apr 16, 2024

Summary

This is a simple PR to plumb through the keep alive settings for the gRPC connections used by the gnmi input plugin, see the related issue for more details.

This PR is push the change against master versus the original PR was against the 1.30 release branch.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves: #15148
rebases: #15149

Co-authored-by: Hunter Kelly [email protected]

This is a simple PR to plumb through the keep alive settings for the gRPC
connections used by the gnmi input plugin, see the related issue for more
details.

resolves: influxdata#15148

Co-authored-by: Hunter Kelly <[email protected]>
@telegraf-tiger telegraf-tiger bot added area/gnmi feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 16, 2024
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 16, 2024
Copy link
Member

@DStrand1 DStrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@srebhan srebhan removed their assignment Apr 17, 2024
@srebhan srebhan merged commit c443b76 into influxdata:master Apr 17, 2024
28 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gnmi feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the gnmi input plugin should support the gRPC Keepalive configuration
3 participants