Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the gnmi input plugin should support the gRPC Keepalive configuration #15148

Closed
retnuh opened this issue Apr 12, 2024 · 1 comment · Fixed by #15149 or #15171
Closed

the gnmi input plugin should support the gRPC Keepalive configuration #15148

retnuh opened this issue Apr 12, 2024 · 1 comment · Fixed by #15149 or #15171
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@retnuh
Copy link
Contributor

retnuh commented Apr 12, 2024

Use Case

When the service on the target end of a gnmi subscription becomes unavailable, "on change" gnmi subscriptions won't notice and won't attempt to reconnect until 2 hours after the last data was received.

The gRPC library already contains functionality to address these issues:
https://pkg.go.dev/google.golang.org/grpc/keepalive

Expected behavior

the gRPC library supports keep alive configuration to handle this appropriately; exposing this configuration will allow the telegraf end user to customize the behaviour of their gRPC connections.

Actual behavior

Currently there is no way to configure the keep alive behaviour of gRPC connections.

Additional info

No response

@retnuh retnuh added the feature request Requests for new plugin and for new features to existing plugins label Apr 12, 2024
@powersj
Copy link
Contributor

powersj commented Apr 16, 2024

next steps: get final reviews in 15149, thanks again for the PR

powersj added a commit to powersj/telegraf that referenced this issue Apr 16, 2024
This is a simple PR to plumb through the keep alive settings for the gRPC
connections used by the gnmi input plugin, see the related issue for more
details.

resolves: influxdata#15148
powersj added a commit to powersj/telegraf that referenced this issue Apr 16, 2024
This is a simple PR to plumb through the keep alive settings for the gRPC
connections used by the gnmi input plugin, see the related issue for more
details.

resolves: influxdata#15148

Co-authored-by: Hunter Kelly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
2 participants