feat(inputs.lustre2): Skip brw_stats in case of insufficient permissions #15045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
feat
lukeyeager
force-pushed
the
lustre2-skip-brw-when-not-root
branch
2 times, most recently
from
df4f9b6
to
bed31ce
Compare
powersj
approved these changes
Mar 22, 2024
powersj
added
the
ready for final review
srebhan
changed the title
srebhan
changed the title
srebhan
approved these changes
Mar 25, 2024
|
@lukeyeager thanks for your contribution. It would be nice if you can resolve the merge conflict... |
lukeyeager
force-pushed
the
lustre2-skip-brw-when-not-root
branch
from
91b91f5
to
73e6be0
Compare
srebhan
reviewed
Mar 26, 2024
Before this commit, the plugin entirely fails when run as anyone other than root, because brw_stats files are symlinks to /sys/kernel/debug/. Which was causing errors like this: ``` 2024-03-22T02:40:40Z E! [inputs.lustre2] Error in plugin: failed to read file /proc/fs/lustre/osd-ldiskfs/MGS/brw_stats: open /proc/fs/lustre/osd-ldiskfs/MGS/brw_stats: permission denied ``` After this change, the plugin continues to run and gather whatever metrics it can, even if brw_stats files are unreadable.
lukeyeager
force-pushed
the
lustre2-skip-brw-when-not-root
branch
from
73e6be0
to
4b5a0ad
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the plugin entirely fails when run as anyone other than root, because brw_stats files are symlinks to /sys/kernel/debug/:
Which was causing errors like this:
After this change, the plugin continues to run and gather whatever metrics it can, even if brw_stats files are unreadable.
I'll rebase after #15042 is merged.