feat(inputs.lustre2): Add health-check metric #15042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, the testsuite can write mock procfs files to standard locations within the tmpdir without needing to specify which files are used. This is really just a precursor for future commits. We want this plugin to "just work", without needing to add more fileglob fields to the config file for each one. Instead, the plugin will search on the standard paths. We won't remove the old .toml fields for backwards compatibility, but they will be deprecated and we will avoid adding new ones. This commit makes it possible to continue using the testsuite in a similar pattern, but we'll only need to fill in "rootdir", rather than globs for each new type of file.
Internally, it is now easier to see the default values for OstProcfiles and MdsProcfiles.
telegraf-tiger
bot
added
feat
|
@lukeyeager thanks for picking this back up! I've pushed a commit to your PR to resolve some linter issues, if you want to take a look. |
|
I saw, thanks! I'm working on a second change right now and noticed that I need to apply my "add rootdir" commit changes to the new brw stuff added in #14813, too. Marking WIP until I get those changes in ... EDIT: done |
lukeyeager
changed the title
lukeyeager
changed the title
This was referenced Mar 22, 2024
powersj
reviewed
Mar 22, 2024
|
Happy to rebase+squash down to a reasonable amount of commits if/whenever you like. |
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
added
the
ready for final review
srebhan
approved these changes
Mar 22, 2024
srebhan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12836. Re-implements #13756 (but with tests and some additional general improvements to the plugin).