Implement uint64 logic into eval #8884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-uint-eval
branch
from
19c8fda
to
83d2fdc
Compare
ghost
assigned
jsternberg
commented
Sep 27, 2017
influxql/ast.go
Outdated
| @@ -3988,7 +3988,7 @@ func evalBinaryExpr(expr *BinaryExpr, m map[string]interface{}) interface{} { | |||
| if !ok { | |||
| return nil | |||
| } else if rhs == 0 { | |||
| return float64(0) | |||
| return int64(0) | |||
There was a problem hiding this comment.
So this is a lot more confusing than I thought it would be. We appear to have an inconsistency. If you do division of two integers in a condition, you get integer division. I verified that the division below is between two integers. But, if you do division between two integers in a field (binary math), you get float division and will get a float (which EvalType doesn't return correctly and so would screw up subqueries).
I think we need to straighten out this behavior and backport that specific section to the 1.3 series.
CC @rbetts
Any operation between an int64 and uint64 results in the type becoming a uint64. This is because the most common will usually be an unsigned cursor being modified by an int literal. Even in cases where we were to add an unsigned literal to an integer iterator, that would just result in it being recast back and overflow.
jsternberg
force-pushed
the
js-uint-eval
branch
from
83d2fdc
to
d474a0e
Compare
benbjohnson
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any operation between an int64 and uint64 results in the type becoming a
uint64. This is because the most common will usually be an unsigned cursor
being modified by an int literal. Even in cases where we were to add an
unsigned literal to an integer iterator, that would just result in it being
recast back and overflow.
Includes a minor fix for dividing an integer by zero (should have resulted in
an integer, but resulted in a float) and I forgot to include UnsignedLiteral in
the logic for EvalType.