Enable uint64 support #8923
Closed
Enable uint64 support #8923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jsternberg
force-pushed
the
js-uint-support
branch
3 times, most recently
from
53cde55
to
3b1aa03
Compare
|
OSS 1.4 is not shipping with |
|
@rbetts are we moving this to enabled by default in the 1.6 general release? |
jsternberg
force-pushed
the
js-uint-support
branch
from
3b1aa03
to
b718f5f
Compare
jsternberg
force-pushed
the
js-uint-support
branch
from
b718f5f
to
eb0386a
Compare
|
During a run of megacheck the following issues were discovered: |
jsternberg
force-pushed
the
js-uint-support
branch
from
eb0386a
to
a828765
Compare
|
This isn't going to land in 1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes were made to support uint64. Each of these changes touched a different part of the system and were made separately to avoid a change that was too large to review.
This change removes the conditional compilation tag for writing unsigned integers into the query engine. Since it is then possible to write unsigned integers, the other parts of the code that exist to support storing and querying the data will now work too.
[Add uint support into the write protocol #8835] Add uint support into the write protocol
[uint64 support in the csv handler #8836] uint64 support in the csv handler
[Unsigned data type parsing and prioritization #8837] Unsigned data type parsing and prioritization
[Support uint64 literals in the parser #8838] Support uint64 literals in the parser
[Add unsigned iterators for all types #8844] Add unsigned iterators for all types
[Support the unsigned type in query.Emitter #8873] Support the unsigned type in query.Emitter
[Implement uint64 logic into eval #8884] Implement uint64 logic into eval
[Add message pack formatter #8897] Add message pack formatter
[Support unsigned binary math in fields #8902] Support unsigned binary math in fields
[Add support for uint64 in the clients #8921] Add support for uint64 in the clients
[Update influx inspect to support unsigned types #8922] Update influx inspect to support unsigned types
[Support marshaling unsigned points #8926] Support marshaling unsigned points
[Add an integration test for writing the uint protocol and reading it #8938] Add an integration test for writing the uint protocol and reading it
Rebased/mergable
Tests pass
CHANGELOG.md updated
InfluxQL Spec updated
Provide example syntax
InfluxData Documentation: issue filed or pull request submitted <link to issue or pull request>