fix(engine) Jump out of the loop when err is nil

[zddr]

close #19841
Add judgment logic

• CHANGELOG.md updated with a link to the PR (not the Issue)
• Well-formatted commit messages
• Rebased/mergeable
• Tests pass
• http/swagger.yml updated (if modified Go structs or API)
• Feature flagged (if modified API)
• Documentation updated or issue created (provide link to issue/pr)
• Signed CLA (if not already signed)

[zddr]

@stuartcarnie

[stuartcarnie]

Thanks for the improvement!

The else if err != nil is unnecessary with your change and possibly clearer as:

switch {
case err == nil:
	break LOOP
case errors.Is(err, ErrSnapshotInProgress):
	backoff := time.Duration(math.Pow(32, float64(i))) * time.Millisecond
	time.Sleep(backoff)
default:
	return err
}

[zddr]

Good idea. I've changed it

[stuartcarnie]

Great catch, however, @benbjohnson might want to look, as he may be actively working in this area.

[lesam]

Fixed a while ago in #20527, closing this one.