Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The createsnapshot() of backup() will be executed repeatedly when err is nil #19841

Closed
zddr opened this issue Oct 28, 2020 · 1 comment
Closed

Comments

@zddr
Copy link

zddr commented Oct 28, 2020

Steps to reproduce:
List the minimal actions needed to reproduce the behavior.

  1. Analysis code Engine.Backup()

Expected behavior:
Jump out of the loop when err is nil

Actual behavior:
no break when err is nil

Environment info:

  • System info: Run uname -srm and copy the output here
  • InfluxDB version: Run influxd version and copy the output here
  • Other relevant environment details: Container runtime, disk info, etc

Config:
Copy any non-default config values here or attach the full config as a gist or file.

Logs:
Include snippet of errors in log.

Performance:
Generate profiles with the following commands for bugs related to performance, locking, out of memory (OOM), etc.

# Commands should be run when the bug is actively happening.
# Note: This command will run for at least 30 seconds.
curl -o profiles.tar.gz "http://localhost:8086/debug/pprof/all?cpu=true"
curl -o vars.txt "http://localhost:8086/debug/vars"
iostat -xd 1 30 > iostat.txt
# Attach the `profiles.tar.gz`, `vars.txt`, and `iostat.txt` output files.
@lesam
Copy link
Contributor

lesam commented Sep 7, 2021

This was fixed by #20527 in master and #19869 in master-1.x

@lesam lesam closed this as completed Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants