Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): redesign alerting index to be responsive #17583

Merged
merged 6 commits into from
Apr 3, 2020

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Apr 2, 2020

Goal is to allow the TreeNav to be in expanded state by default, which we previously couldn't do because this page became so squished that the e2e tests broke.

On most displays the page will only show 1 column at a time, but on larger displays it will show all 3 side by side.

Screen Shot 2020-04-02 at 11 31 14 AM
Screen Shot 2020-04-02 at 11 31 25 AM
Screen Shot 2020-04-02 at 11 31 32 AM

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested review from a team and 121watts and removed request for a team April 2, 2020 18:35
@alexpaxton alexpaxton force-pushed the feat/responsive-alerting-index branch from 36e752d to 1541568 Compare April 2, 2020 22:20
@alexpaxton alexpaxton merged commit b394fdf into master Apr 3, 2020
@alexpaxton alexpaxton deleted the feat/responsive-alerting-index branch April 3, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants