Skip to content

Commit

Permalink
fix(ui): actually fix e2e tests
Browse files Browse the repository at this point in the history
  • Loading branch information
alexpaxton committed Apr 2, 2020
1 parent 27d0ef8 commit 36e752d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
3 changes: 3 additions & 0 deletions ui/cypress/e2e/checks.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ describe('Checks', () => {
})
})
cy.get('[data-testid="resource-list--body"]', {timeout: PAGE_LOAD_SLA})

// User can only see all panels at once on large screens
cy.getByTestID('alerting-tab--checks').click({force: true})
})

it('can validate a threshold check', () => {
Expand Down
2 changes: 1 addition & 1 deletion ui/cypress/e2e/notificationEndpoints.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('Notification Endpoints', () => {
cy.visit(`${orgs}/${id}${alerting}`)

// User can only see all panels at once on large screens
cy.getByTestID('alerting-tab--endpoints').click()
cy.getByTestID('alerting-tab--endpoints').click({force: true})
})
})
})
Expand Down
6 changes: 3 additions & 3 deletions ui/cypress/e2e/notificationRules.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ describe('NotificationRules', () => {
// visit the alerting index
cy.fixture('routes').then(({orgs, alerting}) => {
cy.visit(`${orgs}/${id}${alerting}`)

// User can only see all panels at once on large screens
cy.getByTestID('alerting-tab--rules').click()
})
})
})
Expand Down Expand Up @@ -155,6 +152,9 @@ describe('NotificationRules', () => {
})

it('can create a notification rule', () => {
// User can only see all panels at once on large screens
cy.getByTestID('alerting-tab--rules').click({force: true})

const ruleName = 'my-new-rule'
cy.getByTestID('create-rule').click()

Expand Down

0 comments on commit 36e752d

Please sign in to comment.