Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove "/sources" endpoint #16100

Merged
merged 1 commit into from
Dec 4, 2019
Merged

chore: remove "/sources" endpoint #16100

merged 1 commit into from
Dec 4, 2019

Conversation

nwneisen
Copy link
Contributor

@nwneisen nwneisen commented Dec 3, 2019

Signed-off-by: nwneisen [email protected]

Closes #15571

Describe your proposed changes here.
Remove the "/chronograf/v1/sources" endpoint

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@nwneisen nwneisen changed the title Remove "/sources" endpoint chore: remove "/sources" endpoint Dec 3, 2019
@nwneisen nwneisen force-pushed the remove-source-endpoint branch from 76ca2e4 to 85830c4 Compare December 3, 2019 21:09
@nwneisen nwneisen marked this pull request as ready for review December 3, 2019 23:50
@russorat russorat requested a review from desa December 4, 2019 04:38
desa
desa reviewed Dec 4, 2019
View reviewed changes
Copy link
Contributor

@desa desa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about the additions. Really awesome work!

chronograf/server/config.go Show resolved Hide resolved
desa
desa approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@desa desa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@desa
Copy link
Contributor

desa commented Dec 4, 2019

@nwneisen can you squash these into a single commit and then we can merge it!

@nwneisen nwneisen force-pushed the remove-source-endpoint branch from 86f2f05 to fb03b56 Compare December 4, 2019 15:41
@nwneisen nwneisen force-pushed the remove-source-endpoint branch from fb03b56 to c315c23 Compare December 4, 2019 15:42
@nwneisen
Copy link
Contributor Author

nwneisen commented Dec 4, 2019

@desa This should be ready to go!

I'm looking through other issues for ways I can help. If there's any areas you'd recommend focusing on, let me know and I'll take a look.

@desa desa merged commit 1be8c80 into influxdata:master Dec 4, 2019
@desa
Copy link
Contributor

desa commented Dec 4, 2019 •
edited
Loading

@nwneisen really awesome work!

What types of issues are you interested in? Frontend/Backend/Any?

@nwneisen
Copy link
Contributor Author

nwneisen commented Dec 4, 2019

@desa I'm open to any but more interested in back-end. I found that I like answering questions on SO and learning about areas such as configuration, API, or CLI would help with this.

@desa
Copy link
Contributor

desa commented Dec 4, 2019

Awesome. Some things that would be really great are

#15838
or
#15818

Let me know if there's not enough information in either of these, or if they don't seem interesting.

Also feel free to send me an email at <my github username>@influxdata.com at any point and I'd be happy to find a few more issues that would be good. 😃 .

@nwneisen
Copy link
Contributor Author

nwneisen commented Dec 4, 2019

Sounds great! Thanks for the suggestions! @desa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desa desa desa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove /sources endpoint from the API
2 participants
@nwneisen @desa